Project made with HTML and CSS

Community feedback

• 

  Eray•1,410

  @ErayBarslan

  Posted over 2 years ago

  Hey there, nice work on your solution! Some suggestions:

  • You're using media-query on screens smaller than 375px for mobile version, although content overflows until 700px. For safer approach I suggest designing mobile version first then style for bigger screens by using min-width so you won't ever deal with overflowing issues. Also desktop layouts are usually more complex. By designing desktop first then switch mobile, we're taking that complexity away. So with mobile first approach, we'd be writing less code.
  • Unless you really need to, I'd suggest not giving height to your containers and always let it's children, padding, margin define it's height. Won't matter much for a static card but once you start working with dynamic content, you'd end up with lots of overflowing.
  • Lastly, instead of using fixed width on your containers you can use max-width to keep your containers responsive. Because by default width: auto which is responsive and giving fix value overrides it. Hope these suggestions helps you, happy coding :)

  00