Pass generator app Using React/SCSS/Vite

Community feedback

• 

  Artem Kotko•260

  @artemkotko14

  Posted 7 days ago

  Hi!

  Great job on completing this challenge!

  A few things I'd like to draw your attention to:

  • On a mobile size screen if big length of a password is chosen (for example 20) copy image overflows its container.
  • Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. For example /> here:

  <meta name="viewport" content="width=device-width, initial-scale=1.0" />

  • in your app.jsx

  import TextField from './components/TextField/ index';

  has extra space before 'index' which might cause an error

  • Typo in state setter function: const [passwordLength, setPasswordLenth] = useState(0);

  setPasswordLenth has a typo — it should be setPasswordLength.

  Everything else looks good!

  Keep on coding!

  00