password generator [With HTML, CSS, Js]

Solution retrospective
The most difficult thing in this challenge was writing the CSS codes for the checkbox type input and the range type slider, literally I spent almost two days looking for information on the internet to know how to customize both elements. I finally found some good resources on the internet that helped me solve these problems and I left the links in my github repository in case you are interested in reading
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@AydanKara
This is a well-executed solution @FacundoDLR with minor areas for improvement! 🚀
✅ Semantic HTML
- The HTML structure is mostly semantic, using
<header>
,<main>
, and<section>
. - The use of
<label>
elements for inputs improves accessibility. - A minor issue:
<spa>
in<span class="output" id="password-length-value">8 </spa>
should be corrected to<span>
.
✅ Accessibility
aria-label
attributes are used effectively, e.g., for the copy button and password field.- The password strength indicator uses
aria-live="polite"
to announce changes, which is great. - The range slider should use
aria-valuenow
,aria-valuemin
, andaria-valuemax
for better accessibility. - Consider using
role="alert"
for error messages (e.g., when no options are selected). - The checkboxes work well, but adding
aria-describedby
for further explanation could help.
✅ Responsiveness
- The solution uses
clamp()
for font sizes, which ensures good scalability across screen sizes. - The layout adapts well due to the flexbox/grid approach.
- However, the password field container might become too narrow on very small screens—adding min-width could improve usability.
✅ Code Structure & Readability
- JavaScript is modular and well-structured.
- The function
updateStrength()
correctly updates the UI, but it could be optimized to reduce DOM manipulations inside the loop. - The password generation logic ensures at least one character from each selected category, which is great.
- The CSS variables (
--color-neon-green
, etc.) make the styling reusable and easy to maintain.
Your solution is well-structured, accessible, and visually appealing! You've made great use of semantic HTML, ensuring clarity and readability. The responsiveness of the layout is solid, making it user-friendly across different screen sizes. Your JavaScript is clean and well-organized, with thoughtful handling of user interactions and feedback.
Keep up the great work, and continue refining your skills—you're clearly on the right path to becoming a strong front-end developer. 🚀👏
- The HTML structure is mostly semantic, using
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord