Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

password generator [With HTML, CSS, Js]

accessibility
Facundo Andrés De Los Rios•360
@FacundoDLR
A solution to the Password generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What challenges did you encounter, and how did you overcome them?

The most difficult thing in this challenge was writing the CSS codes for the checkbox type input and the range type slider, literally I spent almost two days looking for information on the internet to know how to customize both elements. I finally found some good resources on the internet that helped me solve these problems and I left the links in my github repository in case you are interested in reading

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Aydan•680
    @AydanKara
    Posted 4 months ago

    This is a well-executed solution @FacundoDLR with minor areas for improvement! 🚀

    ✅ Semantic HTML

    • The HTML structure is mostly semantic, using <header>, <main>, and <section>.
    • The use of <label> elements for inputs improves accessibility.
    • A minor issue: <spa> in <span class="output" id="password-length-value">8 </spa> should be corrected to <span>.

    ✅ Accessibility

    • aria-label attributes are used effectively, e.g., for the copy button and password field.
    • The password strength indicator uses aria-live="polite" to announce changes, which is great.
    • The range slider should use aria-valuenow, aria-valuemin, and aria-valuemax for better accessibility.
    • Consider using role="alert" for error messages (e.g., when no options are selected).
    • The checkboxes work well, but adding aria-describedby for further explanation could help.

    ✅ Responsiveness

    • The solution uses clamp() for font sizes, which ensures good scalability across screen sizes.
    • The layout adapts well due to the flexbox/grid approach.
    • However, the password field container might become too narrow on very small screens—adding min-width could improve usability.

    ✅ Code Structure & Readability

    • JavaScript is modular and well-structured.
    • The function updateStrength() correctly updates the UI, but it could be optimized to reduce DOM manipulations inside the loop.
    • The password generation logic ensures at least one character from each selected category, which is great.
    • The CSS variables (--color-neon-green, etc.) make the styling reusable and easy to maintain.

    Your solution is well-structured, accessible, and visually appealing! You've made great use of semantic HTML, ensuring clarity and readability. The responsiveness of the layout is solid, making it user-friendly across different screen sizes. Your JavaScript is clean and well-organized, with thoughtful handling of user interactions and feedback.

    Keep up the great work, and continue refining your skills—you're clearly on the right path to becoming a strong front-end developer. 🚀👏

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub