password generator with JS , HTML AND CSS

Community feedback

• 

  P

  Jayco•470

  @jayco01

  Posted 3 months ago

  Hey! Great job overall, the UI looks clean, the slider and custom checkboxes are visually sharp. I noticed a couple things that might be worth improving:

  ---

  1. Minor Issue about the App width

  The app gets really wide on large desktop screens. Consider setting a max-width on the main container to limit how far it stretches. That would improve readability and help keep things looking balanced across screen sizes.

  #generator-container {
    max-width: 500px; /* or whatever value fits your design */
    margin: auto;
  }
  

  ---

  2. Critical Issue – Password Generator Logic Bug

  There’s something off about the password generator algorithm.

  When uppercase, lowercase, and symbols checkboxes are selected together, the app breaks.
  Instead of generating a password with a mix of those characters, it just produces uppercase, lowercase, and number characters, but no symbols at all.

  It looks like there's a logic issue in how you're checking checkStates and combining selected categories. You might want to:

  • Double-check how the symbol category (checkStates[2]) is being added to the pool
  • Make sure the combined character set is correctly flattened before random generation

  00