Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping Coming Soon Page

Matheus Pergoliβ€’ 130

@matheuspergoli

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I don't know yet how to validate an email properly, so if you have any feedback I'd appreciate it :)

Community feedback

Vanza Setiaβ€’ 27,835

@vanzasetia

Posted

Hi, Matheus! πŸ‘‹

Congratulations on finishing this challenge! πŸŽ‰ Good effort on this challenge! πŸ‘

You can validate the user input by using RegEx (Regular Expression). Try to create your own RegEx or copy-paste from the existing solution and try to improve it. I've done some research on the internet and I couldn't find the RegEx that fits what I need so, my recommendation is to either create your own RegEx or improve the RegEx that you've found on the internet.

Now, some feedback from me.

  • I highly recommend using classes to reference all the elements that you want to style instead of using id. id is not reuseable and has high specificity which makes the stylesheet hard to maintain. So, using classes would be the best choice to style all the elements.
  • The submit button should have a type="submit" to prevent it from behaving unexpectedly across browsers.

That's it! Hope you find this useful! 😁

1

Matheus Pergoliβ€’ 130

@matheuspergoli

Posted

@vanzasetia Thanks for your feedback!

0
Vanza Setiaβ€’ 27,835

@vanzasetia

Posted

@matheuspergoli You're welcome!

0
Adeniyi Smartβ€’ 520

@Iamweird2

Posted

Hi MatheusπŸ‘‹, nice job so farπŸ‘. To improve your code, follow these tips

  1. Avoid styling elements by name or id, but style elements via class

  2. According to the generated report, you used an element not currently supported by many web browsers, try using an alternative.

  3. Check the generated report and try to resolve as many HTML issues most of which are issues from the CSS transform property.

  4. For form validation, you can use regex in your javascript file, you can find a link to a very simple example below:

Text

I hope this helps, Do have a nice day πŸ‘

1

Matheus Pergoliβ€’ 130

@matheuspergoli

Posted

@Iamweird2 Thanks for your feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord