Ping Coming Soon Page using Sass & JS

Community feedback

• 

  Steven Toben•750

  @steventoben

  Posted over 4 years ago

  This looks pretty great tbh. I only have a couple small critiques which is rare for me when reviewing other peoples' stylesheets. First off I want to say that I love your use of rem units throughout the project and actually using them properly. I also love the inter-activeness from all of the buttons, however I feel like the textbox doesn't reciprocate the same feeling. I know it's a small thing, but even changing the cursor from a pointer to a caret once it has focus, and maybe even throwing an effect on the placeholder text would make a big difference. Another tiny detail that's purely semantics is you shouldn't skip a header level in html. It should go from h1 -> h2, which again isn't really a big deal especially with the fantastic accessibility of the rest of your markup. Your SASS file is pretty big, for a small project like this it's not a huge deal but a few more small improvements you could make would be splitting your variables into a partial, it also seems like you used some styles enough(ex: flexbox) to warrant breaking them off into mixins, perhaps into into another partial with your media query mixins? Another thing is in your last media query I think you nested to deep. For example, your button and input share the same exact set of rules. And here's the last little nitpick: are you using a typographic scale? A lot of your font-sizes are quite weird and stray from a typical modular type scale and I'm curious how you came to those numbers. Also you also never include line-height or letter-spacing into any of your text. I honestly had to dig pretty hard to find anything wrong with this, overall it looks pretty amazing and no one would ever really notice such small details. Great work!!

  11
• 

  Gerben Dol•3,115

  @GerbenDol

  Posted over 4 years ago

  Hey Nafsuki!

  Your solution looks great - really well done! 🤩

  One thing I'd consider paying attention to is the nesting of your SASS. Right now your style on, for example, your h1 only works as long as it is in the .container. Do you really need that depth in your selector or risk the style breaking as soon as it is used outside of the .container?

  In a small project like this obviously it's no problem at all, but keep this in mind on bigger projects! 😄

  11
• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hello, Nafsuki! 👋

  Just wanted to say, nice to see you complete another challenge yet again! 😀 Good work on this one! 👍 Your solution looks great and I like the hover state you gave to the button! 😉

  Keep coding (and happy coding, too)! 😁

  01