Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping comming soon page (mobile first)

michuux 100

@michuux

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


First challenge completed!

Hi. Thank you for looking at my work. I am a beginner so please tell me if you see anything I can improve on.

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @michuux 👋🏻

I have some suggestions to help you fix the HTML issues and some other things.

  • Instead of <section>, in this case, I suggest using regular <div> for a couple of reasons. First, when you use a <section> you have to have a heading, like h2-h6. Next, <section> is for bigger parts of a layout, such as, contact us about us, image gallery, etc.
  • Next, <p> cannot be a child of <label>, just take it out. These will fix the HTML issues. Just, don't forget to generate a new repot once you fix the issues.
  • Also, when I click the button it shows the default errors of the browser instead of the custom errors, provided by the original design.
  • One last thing, on desktop viewport width, the footer with your links is all the way on top right corner.

I hope this was helpful 👨🏻‍💻 for the first project, you did a great job, especially with responsiveness, well done. However, if you need a reference point, you can check out my solution. Cheers 👾

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord