@mattstuddert
Posted
Nice work, Riyana! Your project looks great! Here are a few small pieces of feedback:
- Instead of leaving the logo
alt
text blank, I'd add the name of the company. So, in this instance, it would bealt="Ping"
. That would help screen readers users know what the site is. - This is a small UX thing but I'd avoid removing the error message on input focus. The error message is there to help guide someone, so it helps to keep it visible until the error has been resolved.
- When adding error messages, you can use the
aria-live="polite"
attribute to ensure updated messages are announced to screen reader users. This is a big help when form validations kick in.
I hope those points help. Let me know if you have any questions!
Marked as helpful
@rngueco
Posted
@mattstuddert That makes a lot of sense. Thank you, Matt!
Thanks also for informing me about aria-live
, I didn't know about that beforehand.
Changes should be up in a few. Cheers!