Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping page with Grid

@fawadmehmood

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback will be highly appreciated.

Community feedback

Arturo Simon 1,785

@artimys

Posted

Nice job Fawad, the error message effect is really fancy 👍

Your form responds well but your image responds toooo well that it gets really small or large. I would either putting a max-width on your main container or to the parent container of your image. Actually your main container can benefit also as everything gets really stretched out on wider screens.

The h1 text can better a bit more larger and the subscribe text doesn't have to be too bold.

Javascript:

  • It's great that you added your styles to a classes to activate. To improve on it, create an .form-errors class toyour form. Inside that class place your other styles that style the border and show the message. That way only one class actives the styling errors.

  • You can clean up your nested if statements with just one if else if statement.

    if ( input.value == '' ) { 
         // code
    } else if ( !validateEmail(input.value) ) {
        // code
    }

Keep on coding!! 👍

0

@fawadmehmood

Posted

hi @artimys, thank you very much for this feedback. I will definitely make these changes.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord