@vanzasetia
Posted
Hi, Dave Quah! 👋
It is correct to use aria-live attribute and you need to add aria-describedby attribute to the <input> element to programmatically connect the error message with the <input>.
I recommend adding novalidate attribute to the <form> element through JavaScript. This way, if the JavaScript fails to load, the users still have the native form validation.
The alternative text of the logo should be "Ping" instead of "company logo". Remember, for images containing text, make sure the alternative text includes the image's text.
I notice that the website uses Google Analytics. Be aware that it is illegal in some countries.
Learn more — Is Google Analytics illegal? Austrian, French, Italian and Danish DPAs say so
I hope you find this useful. Happy coding! 😄
Marked as helpful
@vanzasetia Thank you for your feedback! I will make the suggested changes.
Just to clarify, do you mean removing novalidate as it is already set on the form which prevents native form validation?
@vanzasetia
Posted
@Milleus
You are welcome!
I don't understand what you mean. But, by default, the novalidate attribute should not be in the HTML. It should be added through JavaScript.
@vanzasetia OHH, I get what you mean 😂
I should be adding novalidate to the form via JavaScript instead of HTML so that in the event where JavaScript fails (which means novalidate wouldn't be added), the form would still have native form validation.
Apologies, my brain sometimes 🤪🤪🤪 Thanks again!
@vanzasetia
Posted
@Milleus
Yes, that's exactly what I meant. 😉
No worries at all! 👍
