Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping Single Column Coming Soon Page

@TheLiberal

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Javscript was the hardest part here since I forgot all the techniques useful in such a validation and updating the DOM.

Community feedback

Arturo Simon 1,785

@artimys

Posted

Nice Job!! A few suggestions to improve your JS.

  1. remove duplicate <p class="warning-message2> tag which would do away with checking window.innerWidth (see code below)

  2. create a class (call it .error) on your form to style the errors. This class would style the input red border and display the message. Add/ remove class with JS instead of changing multiple styles

- wrap input and button in its own div
- style the div so it stacks on mobile and floats next to each other in desktop
<form id="form">
    <div class="input-group">
        <input type="email" placeholder="Your email address..." id="email">
        <p class='warning-message1'>Please provide a valid email address</p>
    </div>

    <div class="input-group">
        <button id="notify-me" type="button">Notify Me</button>
    </div>
</form>

Keep on coding!!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord