@VCarames
Posted
Hey there! š Here are some suggestions to help improve your code:
- Company logo's
alttag descriptions should NEVER include the keyword "logo"; It should only state the company's name.
- Remove all the
articleelements you added, as they are being used incorrectly and not needed for this challenge.
- Your
email inputis missing alabelwhich will bevisually hidden.
- The illustration is purely decorative, so it's better off to leave the
altdescription blank.
- The social media logos need to interactive. So they need to be wrapped inside an
anchorelement. They should also be built as anunordered list.
- The JS for your
email inputvalidation needs work, asemail@[email protected]is considered valid. You also want to add some sort of confirmation to valid emails as I wasn't sure if the validation was working.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! š¾
@kevinfreitasv80
Posted
- I do understand some points, but from my perspective (in this case), it's not necessary to include an
anchor/aelement because it's not for a person/client; it's just a project that will be on my GitHub. But I do understand your suggestion, and I'll make the adjustment soon. - There's just one thing I didn't quite get ā why should I remove my
article? "The<article>element in HTML is used to mark content that is independent and complete, like a logical unit that can be distributed or reused autonomously." - ChatGPT. It even mentioned that I could put my element inside adiv, but from my perception, it wouldn't be as semantic. Nevertheless, I'll use adivbecause it's used for grouping structures, and thearticledoesn't really seem that independent but more like a related element.
@VCarames
Posted
@kevinfreitasv80
- Not a valid justification for neglecting the use of proper elements because failing to do so will only demonstrate a deficiency in knowledge.
Projects serve as a platform to showcase your expertise and skills to recruiters and fellow developers, providing them with insight into your proficiency. Employing incorrect elements will merely indicate to others that you lack essential coding skills.
- You are indeed correct in your understanding of the
articleelement's purpose, but it's essential to note that the content you used it on doesn't align with that description.
Content designed for the article element can be used on ANY random website and make perfect sense regardless of its placement.
A good example of this would be the QR code component challenge
More Info: https://www.w3.org/TR/2011/WD-html5-author-20110809/the-article-element.html
