Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping single column coming soon page

@radenadri

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My solution for this challenge, any feedback are welcome ✌😁

Community feedback

P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Yeah, nice job, Adriana Eka Prayudha! 👍

Your solution looks pretty good and responds nicely! 🙌

Just make sure (in addition to following artimys' helpful suggestions) you make your input element accessible (you might be able to turn the "Subscribe and get notified" element into a label or something) and this StackOverflow query might help you resolve the other HTML issues in your solution report.

Keep coding (and happy coding, too)! 😁

0
Arturo Simon 1,785

@artimys

Posted

Nice job Adriana, solution responds well.

Some minor suggestions:

  • I'm glad to see you're using semantics but I believe your <footer> should not be a child in the <main> container. As is it gives the meaning that your footer content is part of the main topic of your content. I try to keep header, main, and footer adjacent to each other.

  • In your JS, I suggest creating a class for your form and apply the email and small styles.

Great job overall 👍👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord