Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping single column coming soon page

yesim 170

@ysmltr

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feedbacks are welcome!

Community feedback

hao pham 745

@jerry-the-kid

Posted

Hi Yesim. Your web works great in desktop but there are some things to avoid like using margin left like 22rem. It's not good practice in responsive, what if your screen really big (the input and the picture will only on the left and remain big space in the right) and what if your screen like in tablet or mobile ( it will overflow outside the screen or it will on the left only ).

My solution it you do like you usually do like set width and max-width and margin 0 auto so the item in center. I usually do that to. And for helper text you should use left : 10% or so replace to margin-left.

Marked as helpful

1

yesim 170

@ysmltr

Posted

@jerry-the-kid hi man! I know it's not a good choice, but I use this style: "justify-content: center; " I hope it's better what do you think about this

thank's for feedback again!

0
hao pham 745

@jerry-the-kid

Posted

Hi @ysmltr, It look great but your input sink too fast because you set input width = 40% and button 10%. For an example you can set input like width: 80%; max-width: 450px; ( so in large screen it took 450px, and small screen it took 80%).

My recommend method is set button-group max-width and width and make it center using margin : 0 auto. Then the input i set it to 70% and button 30% something like that (or other modern way is set flex in button-group and input flex-grow and input set flex-basis on button 100px or something).

and i notice your border not showing correctly. Please remove border-radius: 2rem solid black, and divide it to 2 attribute like : border-radius : 2rem, border : 1px solid red, or something like that.

I’m glad I could help. I’ll happily do it again, too. Just let me know if you have any problems.

Marked as helpful

1

@Bishalsnghd07

Posted

Hey, unable to see your feed image in mobile view, may be your media queries prevent to display the image in mobile. Please do correct it

1

yesim 170

@ysmltr

Posted

hey bishal thanks for feedback and do you know how could I add media queries? any source tips etc.? so I can fix it? @Bishalsnghd07

0

@Bishalsnghd07

Posted

@ysmltr I would like to share you a source for getting understand media-queries properly, this is the topic that you need to learn by yourself and get hands-on experience, rather than getting theory knowledge from me, I would share this link to you to get your hands flexible in media-queries, here is the source link of it 👉 Media Queries

And also, you will get some free courses in frontend mentor resources page in this website as well, you just need to click on above Navbar and explore best course for yourself☝️

Hope, this will help you, if need any help then feel free to ping me!

Happy Coding and wishing you a joyful journey ahead in frontend mentor❤️

Marked as helpful

1
yesim 170

@ysmltr

Posted

thanks for helping @Bishalsnghd07

0

@Bishalsnghd07

Posted

@ysmltr Sorry for that. I have to add media queries from my side for that I have to clone your repo into my pc and will have to start from beginning with adding media-queries, because you did not even use media-queries anywhere, if you atleast add media queries in some component where needed, then I can easily inspect from the web page and then I able to do some certain changes. Without it I can't. Browser did not give permission to add media-queries from my side. I just make edit in your solution only, that permission is only given by browser, but you unfortunately not added media-queries🤷

1
yesim 170

@ysmltr

Posted

I will do it tomorrow and tag you, so you can help, thank you for your support.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord