Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Ping challenge with React and Scss

Guy Ezra 615

@ezraguy

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is welcome.

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, nice job on this challenge, Guy Ezra! 👍

Your solution looks good and the form validation works well (I like the little notification that pops up after valid input has been submitted)! 👏

I suggest,

  • Adding cursor: pointer to the social media icons at the bottom of the page and adding a little padding around the icons themselves to separate them from the border around them.
  • Adding some space around the hero image (using margin or padding) so that it isn't right up against the edges of the screen in the mobile layout.

Keep coding (and happy coding, too)! 😁

1

Guy Ezra 615

@ezraguy

Posted

Hello @ApplePieGiraffe, Always a pleasure getting feedback from you! I've fixed the issues you mentioned. thank you so much! 😄

1
P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

@ezraguy

Just took another look at your solution, and the changes you made look great! Keep it up! 👍

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord