Planets fact site

Community feedback

• 

  P

  Miran Legin•740

  @miranlegin

  Posted almost 3 years ago

  Hi Mok,

  first of all congratulations on completing this challenge!

  I think your solution looks great, i really like the slider feel of the page when you move between planets. You did a great job with this project.

  Like always there are things that can be improved so let's get started.

  Desktop:

  1. on screens larger than 24" there is a lot of white-space bellow the content, i think that can be improved with some calculations regarding available height etc.. to create more balanced look
  2. also on Venus page, third tab "Surface Geology" has somewhat longer text and shifts the whole page up and down when you toggle between other tabs on this page; same experience can be seen on other pages aswell
  3. below 1200px of resolution when the navigation wraps below the logo after the transition ends page shifts from the top for around 20px or so, it seems like when animation is active whole thing is shifted up and when it finished it goes back down for some reason

  Mobile:

  1.mobile navigation when active is placed near the top of the page, needs some shifting down because right now if covering the logo area a bit,

  .el-dialog__wrapper {
      ...
      height: calc(92vh + 4px);
      ...
  }
  

  needs to be

  .el-dialog__wrapper {
      ...
      height: calc(92vh - 27px);
      ...
  }
  

  at least on my machine.

  Other than that like i said earlier it is great attempt and nothing major to add here.

  Cheers, Miran

  11

  Marked as helpful