Pod landing page using flex/gridbox in sass with some basic js

Community feedback

• 

  Raymart Pamplona•16,040

  @pikapikamart

  Posted almost 4 years ago

  Hey, good work on this one. Both desktop and mobile layout is good, and scales well just to say.

  Suggestions would be:

  • the img on your header tag could have an alt text. You could use alt="pod" like the text on the image, because it seems it is the company's name if you think about it. This gives more meaning for other user.
  • The text PUBLISH YOUR PODCASTS EVERYWHERE. could have been wrapped inside a single h1 element. This will make your html error go away since you need a h1 on a page. You could wrap the everywhere text in a span then give it a display: block so that it will go underneath the first text like on the design. That way you avoid 2 h2 declarations.
  • on the warning message on the form. Instead of transitioning the color of it, to make it more better for screen reader, transition the visibility property. This will allow a screen reader to only read an element, if it is visibility: visible, thus removing a confusion for SR users because it will read that error message even if they successfully submitted the form, because you are only transitioning the color
  • button type="submit" is much preferable than input type="submit" I have read it somewhere that it is the preferred way now.

  Other than those, really great job. Your html structure is quite good to be honest, just needed that one h1 right :>

  10

  Marked as helpful
• 

  Naveen Singh•75

  @naveensing575

  Posted almost 4 years ago

  **Missing things: Input-Placeholder & singer-image and also site is not uploaded properly on netlify!

  Besides, you have done good code formatting 👍

  10