Mohamed ELIDRISSI• 455
@elidrissidev
Posted
Looks very close to the design, great job!
I do have some suggestions for you:
- When you submit a solution, try to take a look at the reports page as it helps you identify accessibility and semantic issues with your HTML.
- Speaking of semantics, you could have used some semantic elements instead of generic
div
s. E.g: You could wrap.attribution
with afooter
element, and you could also make.card
amain
element or wrap it in one. These are called landmark elements and they help create a hierarchy of the page for things like screen readers. - Avoid skipping heading levels. You've used an
h1
for "Order Summary" but you skippedh2
and used anh3
for "Annual plan". Heading levels help define a content hierarchy for your page, always go from 1 to 6. - Since you are practicing BEM methodology, I saw that you were using long class names for nested elements, you could simplify it by flattening it: http://getbem.com/faq/#css-nested-elements
Good luck!
0