Melvin Aguilar ๐ง๐ปโ๐ปโข 61,460
@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
- The product image is not a decoration. You must not use the background-image property to add the product image. Instead, use the
<img>
and<picture>
tag to add the image. Use the background-image property only for decorative images that do not add any information to the page.
CSS ๐จ:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. Source ๐.
- The
width: 100vw
property in the.container
tag is not necessary. This will create a horizontal scrollbar on some devices.
- Use
min-height: 100vh
instead ofheight: 100vh
. Theheight
property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
I hope you find it useful! ๐
Happy coding!
Marked as helpful
0