Skip to content
Submitted about 4 years ago

Price Component

David Maillard•375
@DavidMaillard
A solution to the Single price grid component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hi guys,

Feedbacks are really welcome !

🤘🤘🤘

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • Vanza Setia•27,715
    @vanzasetia

    👋Hi David Maillard! My name is Vanza!

    I have some feedback on this solution:

    • For the .list you can use ul and li rather than p and br tags.
    • Try to use rem unit. It's simply because it allows the user to change the font size based on their setting.
    • For the line-height and letter-spacing, I recommend to use em unit since they will adjust base on font-size
    • I see that you use will-change property on .button, which is in my opinion, is too over kill since the purpose of will-change is to optimize and fix existing performance problems. For just changing background-color is not a big problem in terms of performance.

    I have a question for you, are you a professional developer? If yes, then can you explain to me why you need to license this project?

    That's it! Hopefully this is helpful and you can answer my question!

    Happy Coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord