@ApplePieGiraffe
Posted
Greetings, Anthony! ๐
Good job on this challenge! ๐ Your solution looks good, is responsive, and the toggle-switch works rather well! ๐
It's nice that your toggle-switch is keyboard-accessible, but it might be worth using a few more semantic HTML tags from the start (rather than building the entire component out of div
elements). For instance, you could perhaps use a button element or a checkbox to make the toggle-switchโboth of which are a little more inherently meaningful. Here's a great solution for this challenge from Grace that focuses on accessibility that you might be able to learn a thing or two from. ๐
And small tip for the design of the solutionโit might be worth allowing the container that holds the background color and images for the site to expand to fill up the entire area of the viewport. That way, there won't be any empty white space to the sides of the design on extra-large monitors.
Hope you find those one or two tips helpful. ๐
Keep coding (and happy coding, too)! ๐
Marked as helpful