Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product card using HTML and CSS

@Spsingh0005

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Kuraanal 210

@Kuraanal

Posted

Hey!

Seems like your first import for the "Montserrat" font is wrong. you could import the 2 required font in a one line like this :

@import url('https://fonts.googleapis.com/css2?family=Fraunces:wght@700&family=Montserrat:wght@300;500;700&display=swap');

Also, you should define the main font family on either 'html' or 'body'. Every elements inside them will inherit the property by default. You can then apply another font only to the tags that need it.

html {
font-family: Montserrat;
}

Hope this help.

Marked as helpful

0

@Spsingh0005

Posted

@Kuraanal Thank you for your solutions, appreciate that. I will fix those issues and hope to get future recommendations as well.

0

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.
  • So resolve the issue by replacing the <div class="card-container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@Spsingh0005

Posted

@0xAbdulKhalid Thank you for your solutions, appreciate that. I will fix those issues and hope to get future recommendations as well.

0
Adeola Ganiu 1,320

@Deolabest

Posted

Hey @Spsingh0005, Congratulations on completing this challenge!

Here is my feedback:

  1. You're using about 3 different font-family that's making the required one for the project Montserrat not to work.

    • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

Keep doing a good job!

Marked as helpful

0

@Spsingh0005

Posted

@Deolabest Thank you for your solutions, appreciate that. I will fix those issues and hope to get future recommendations as well.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord