Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

product list cart

Yasir Abbas•1,100
@yasir-abas
A solution to the Product list with cart challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Raul Galicia•230
    @raulgaliciab
    Posted 4 months ago

    Hi Yasir,

    Great solution! These are the points that I could see as a feedback:

    Overall project.

    • Having all the logic in one file may not be very readable and maintainable in the long run. With vanilla JavaScript, you could try using ES Modules.
    • Since you are using data.json, the content.txt file seems to have no purpose in the repository.
    • Don't forget to update the README.md with your insights. One of the points of doing the projects is to be able to show the results proudly. :)

    Checkout Modal:

    • You can still scroll the rest of the content when the modal is open. Try to add these styles to the body when the modal is open: overflow: hidden; height: 100vh;
    • If the content in the modal is too large you can't see it complete. One style that could help with this is overflow-y: auto;

    Images:

    • You are just using the mobile version of the images. For dynamic display according to screen resolution try the <picture> HTML tag.
    Marked as helpful
  • Muhammad Siddiq•1,590
    @MS-80
    Posted 4 months ago

    good effort try to improve more

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub