Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 7 months ago

Product List with Cart - Angular

angular, typescript
P
Dave•5,295
@dwhenson
A solution to the Product list with cart challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

A step up in terms of complexity and building things with Angular. I feel like this went OK, but more practice is needed.

What challenges did you encounter, and how did you overcome them?

Typescript continues to be a challenge, but I can see its benefits. I am also reaching into the DOM and have concerns about mutating state that I need to better understand.

What specific areas of your project would you like help with?

I've a couple of questions I'd love feedback on - mostly based on my experience with React:

Am I mutating state and does this matter? In the button component I am increasing/decreasing the quantity within the component rather than destroying and updating the state in DesertsService. Everything seems to work OK, but I'm not sure if this is bad practice?

Reaching into the DOM... I'm reaching into the DOM to remove items from the Cart component. I feel like this is wrong. From working with React I feel like I should be handing this over to Angular to take care of rather than using querySelector.

I am also using the native HTML dialog element and methods for the modal. Again this feels wrong, and being able to dismiss the modal with the escape key knocks state out of sync. I used @viewChild to access the dialog, but honestly, I just pasted this in with little understanding.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on Dave's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.