Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

Product page. HTML, CSS, SCSS.

accessibility
nimbo•100
@7bibi
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Not very proud. Gave up on making it responsive.

What challenges did you encounter, and how did you overcome them?

I couldn't center and contain the elements! Don't know why, tried many ways. I started with desktop first then mobile, and I still got the same issues.

What specific areas of your project would you like help with?

I want to redo the whole project. If someone can suggest a specific way and methodology that I can follow to match the exact design and improve, please do comment. What are the best ways to center containers for these projects? And how to determine what to use from the beginning.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Asilcan Toper•2,960
    @KapteynUniverse
    Posted 9 months ago

    NEVER GIVE UP

    Looks like you did it. It is just too big.

    If someone can suggest a specific way and methodology that I can follow to match the exact design and improve

    It doesn't have to be pixel perfect. It needs an educated eye to determine exactly how big are the gaps, fonts etc. without figma file. But best way i think is to look both mobile and desktop design and determine which things are belongs in which group (like you did here; 1 img container and 1 text container together in a container) and decide when/how to change layouts then start with mobile to desktop.

    Also use a css reset everytime

    What are the best ways to center containers for these projects?

    Flex or Grid. Which one to use? It is personal choice most of the times. You can make a 5x5 grid with flex but that wouldn't be efficient ofc.

    If you are asking to center whole product card and other challanges, this should do the trick

    body {
    min-height: 100vh;
     display: flex;
     justify-content: center;
     align-items: center;
    }
    

    I guess you had problem with the second col which you can solve using flex and space between.

        div.second-col {
            width: 100%;
            padding: 30px !important;
            overflow: hidden;
            display: flex;
            flex-direction: column;
            justify-content: space-between;
        }
    

    For div class="container" i think you can use article tag. The <article> tag specifies independent, self-contained content. An article should make sense on its own and it should be possible to distribute it independently from the rest of the site.

    In your code you commented that picture tag doesn't work but looks like it is working, but i think you can delete source element with the mobile picture and switch src attribute of the img tag to mobile picture. With this way card will display mobile picture until min-width of 768px. In your code it displays desktop picture then switches to mobile at 320px then switches to the desktop again at 768px.

    Also for this project i think only 1 media query is enough, which is i think needs to match with the picture elements min/max width size.

    Lastly Kevin Powell made a video for this challenge. You can check that too.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub