Product preview card component

Community feedback

• 

  Adriano•42,870

  @AdrianoEscarabote

  Posted 8 months ago

  Hii, Sapphire!!

  how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  Everything else looks great.

  Hope this helps! 👍

  11

  Marked as helpful
• 

  

  Grace•32,130

  @grace-snow

  Posted 8 months ago

  I'm afraid this is overflowing my screen at the moment.

  But before getting to css issues —which appear to be caused by setting lots of widths and heights— it's important you first fix the html. Read this post about how to translate the design into html and make those changes to your code first.

  Then move the font links into the html head as its better for performance than using css imports (Google fonts will give you the code to add once you select the families and weights you need).

  Once those things are done we can cover the css improvements.

  13

  Marked as helpful