Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

@catherineisonline

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, Frontend Mentor community! This is my solution to the Product preview card component.

I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.

You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.

Thank you

Community feedback

P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hey there, Catherine Is Online! 👋

Great job on this challenge! 👏 Your solution looks good and responds well! 🙌

One thing I'd suggest is to probably not set the font-size of the text in the body in px because we typically want to users to be able to change the size of all text on the site by the changing the root font-size of the document. In other words, setting font-size in em or rem wherever possible would be the better way to go in order to make your solution as accessible as possible. 😉

Hope that helps. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

3

P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

@catherineisonline

You're welcome! 😊

0
faizan 2,420

@afaiz-space

Posted

Hey @catherineisonline, remove height: 450px; from main element.

Marked as helpful

1

lilKriT 380

@lilKriT

Posted

Very cool and clean. It almost looks like the design is a screenshot of your implementation.

Marked as helpful

1

@DkP-Consult

Posted

Well good job ! Just may be use bold propertie for promo price :) Friendly, DkP

Marked as helpful

1

MazzCode 120

@MazzGuille

Posted

Hi, I think the only suggestion I can give you is to set the font size on HTML or body to 62.5%, this makes 1rem = 10px, that way you can use rem units to set specific font sizes on different elements. I.E., by setting font size to 62.5%, if I wanted a <p> tag to be 16px, I would set it like this:

html { font-size: 62.5%; }

.my-p-tag{ font-size: 1.6rem; }

This also helps because you can use rem units for padding, margins or any other measurement you need

Hope it's helpful for you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord