Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Product preview card component

kokenydaniel•50
@kokenydaniel
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Oscar Bocanegra•235
    @obocanegra-dev
    Posted about 2 years ago

    Hello kokenydaniel! 👋

    Congratulations on your incredible work in the Frontend Mentor challenge! 🎉 You've done a great job, and I would like to offer you some suggestions to further improve your project:

    I noticed that the card container appears large on small screens because the width is fixed. I recommend adding a max-width property to the container to make it better fit on smaller devices. This will help your design look more balanced and responsive.

    I suggest adding a breakpoint earlier, with a higher number of pixels, as 375px is quite low. This way, you can ensure that your design looks good on a wider range of screens and devices.

    I recommend using semantic elements in your HTML instead of relying too much on generic divs. This will help improve the structure and accessibility of your code by providing clear semantic meaning to each section of your page.

    For your next project, I strongly recommend adopting the "mobile first" approach. Starting with designing and developing for mobile devices will allow you to build a solid foundation and ensure an optimal user experience on all devices.

    Additionally, consider taking advantage of the current design to add interesting interactions with the hover effect on the button. This can add an interactive and appealing touch to your project.

    Overall, I want to congratulate you again on your work. You've truly achieved something great! These suggestions are meant to help you take your project to the next level.

    Keep up the great work and don't hesitate to explore more challenges on Frontend Mentor to continue improving your skills! 💪

    Wishing you much success in your future projects! 🚀✨

    Best regards, Oscar

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub