Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

Lasha 50

@lashaarveladze

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey guys 👋 Hope you have a great day!

This is the first project which I made here and I have some questions about it.(Just learning HTML & CSS)

  1. Can you give me some advice about how to write clean code? What you will change into my code to improve it?

  2. Also I am struggling to make responsive design and will be happy if you give me some advice about that too.

Thank you 💖

Community feedback

@tesla-ambassador

Posted

Hey Lasha, this is a very neat solution congratulations on completing your first frontend mentor project 🥳 To answer your questions:

  1. Your code is very neat and organized! Both the HTML and CSS, I wouldn't change anything apart from adding landmarks in your HTML because In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
  2. Responsive design has always been a hustle for most people when starting out with CSS and I am no exception 😂 but you get the hang of it the more you practice making responsive designs and incase you'd just want to expand your knowledge with responsiveness you could check out this tutorial (Follow this link) [https://youtu.be/Xig7NsIE6DI]. I hope it helps you!

Ps: Your heading tags should only increase by one ie when you have just used a <h1> tag, your next heading tag should be <h2> and after that <h3> and it continues like that all the way to <h6>. So they have to be in a sequential order. This will also clear some more of your accessibility issues.

Happy coding and keep up the good work!

Marked as helpful

1

Lasha 50

@lashaarveladze

Posted

@tesla-ambassador Thank you🤩 you helped me a lot

1
Lasha 50

@lashaarveladze

Posted

@tesla-ambassador Heyy I made a responsive design and there are no accessibility issues anymore. Thank you🥰 (The video was helpful)

1

@tesla-ambassador

Posted

@lashaarveladze You're welcome! I am glad that I could help and that the video was helpful.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord