Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Product Preview Card Component

accessibility
Mehmet Ali Meşe•130
@mehalimes
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I open for every comment.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Daniel 🛸•44,810
    @danielmrz-dev
    Posted over 1 year ago

    Hello @mehalimes!

    You did a very good job there!

    I have a very simple suggestion for improvement:

    • Since the button is a clickable element, it's nice to add cursor: pointer to it.

    📌 This gives the user one more visual indication that the element is clickable, as obvious as it may look.

    I hope it helps!

    Other than that, you did a great job!

  • raya•2,870
    @rayaatta
    Posted over 1 year ago

    Hello 👋 Mehmet Ali MEŞE, congratulations on completing this challenge 🎉.

    I have some bits of advice for you

    1 Let me introduce you to the Mobile-first workflow

    The mobile-first workflow refers to a design approach where websites or applications are designed for mobile devices initially, and then adapted for larger screens such as tablets and desktops. This is due to the increasing number of people accessing the internet on their mobile devices, making it essential to prioritize mobile user experience.

    Importance of the mobile first work flow

    Responsiveness:. Websites or applications should be developed to automatically adjust their layout and content to fit different screen sizes. This ensures optimal user experience regardless of the device being used. You can learn more about it here

    2 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div id="container"> With <main id="container">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

    SEO

    And user experience (accessibility) for people using assistive technology such as screen readers.

    I hope this helps 🙃

    Your solution looks great 😉

    Happy coding ✌️

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub