Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Product Preview Card Component

sass/scss
Dev Gobind Ganguly•30
@devgobind
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Mobile First -> Desktop Used background-image property to control the image size. Need to learn how to control the size of image using <img> without distorting the image

Please share the feedback it is much appreciated

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Adriano•42,870
    @AdrianoEscarabote
    Posted over 2 years ago

    Hi Dev Gobind Ganguly, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

    Example:

    body {
        margin: 0;
        padding: 0;
        display: flex;
        align-items: center;
        justify-content: center;
        min-height: 100vh;
    }
    

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
  • Fritz•300
    @fritzadelbertus
    Posted over 2 years ago

    Hello @devgobind. First of all, congratulations on finishing this challenge!

    Here are some few suggestion I can give:

    • Using <picture> tag is a better practice in this challenge where the image source change according to the screen width. See this on how to use it.
    • The <h1> tag is used for the main header of the document so I suggest changing the
    <div class="price btm-pad">
           <h1 class="d_price">$149.99</h1>
           <p class="o_price">$169.99</p>
    </div>
    

    to something simpler like this:

    <p class="price">$149.99<span class="o_price">$169.99</span><p>
    

    I hope it's helpful and happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub