CSS Media Queries

Community feedback

• Account deletedPosted over 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Congrats on completing your first challenge!🎊🎆

  • The image’s alt tag description needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints ⚠️. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Do not capitalize ❌ "perfume" in HTML as it is not accessible friendly. Instead you will want to style it in CSS.

  • Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  02

  Marked as helpful
• 

  Hassia Issah•50,410

  @Hassiai

  Posted over 2 years ago

  Replace<div class="container">with the main tag, <div class="perfume"> with <p>, <div class="title">with <h1>, <div class="description"> with p and <div class="attribution"> with the footer tag to fix the accessibility issues. for more click here

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use relative units like rem and em as unit for the width , margins , height and paddings. for more Click here In the media query, give .container a max-width value and a flex-direction: column, the rest of the styling are not needed. there is no need to give .mobileImage a height value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  00

  Marked as helpful