@sulemaan7070
Posted
hey π, congratulations on completing your first challenge... here are a few tips to make your site better.
1.I see that you have used .container
-> height:90vh
...using height:90vh
π« is a bad practice you can use min-height:90vh
β
or 100vh.
2.Using the picture element for responsively switching between Images is considered as best practice
<picture>
<source media="(min-width: 650px)" srcset="img_food.jpg">
<source media="(min-width: 465px)" srcset="img_car.jpg">
<img src="img_girl.jpg">
</picture>
more about picture element hereπ
Hope that helps, happy codingπ₯π₯
Marked as helpful
@Kure-ru
Posted
@sulemaan7070 Hi, thank you so much for your feedback!
I learned a lot thanks to your comment! π