Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 10 months ago

Product preview card component

accessibility, sass/scss
P
Emilia Burza•780
@eburza
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of using SASS for the first time

Next time I will improve my SASS functions

What challenges did you encounter, and how did you overcome them?

It was first time for me to use SASS, it looks easy, but I had to check documentation many times and spend a lot of time reading about it before I actually wrote anything

What specific areas of your project would you like help with?

I would like to get help with my SCSS code, for now I don't know how many mistakes I made and what I could do better

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    MikDra1•7,450
    @MikDra1
    Posted 10 months ago

    I see in your code that sometimes you have sth like this: 0.3125rem;

    I encourage you to set a font-size on html to 62.5%. Then one rem is equal 10px. After this your calculations would be easier because you would know that one 1rem = 10px

    html {
    font-size: 62.5% // It means that 1rem = 10px. From this it is easier to use rem
    }
    
    p {
    font-size: 1.6rem; // Here this paragraph font-size will be 16px;
    }
    

    Hope you found this comment helpful 💗💗💗

    Good job and keep going 😁😊😉

    Marked as helpful
  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 10 months ago

    Hi Emilia,

    Nice project! I noticed a few areas for improvement:

    Simplify Centering: I noticed you’re using a <div> to center the page. Keep in mind that any element, including <body> and <html>, can be a flex container. By reducing unnecessary <div> elements, you can simplify your code.

    Enhance Accessibility: When you need to use <div> elements, consider adding aria-labels to help screen readers understand their purpose. This will improve both accessibility and SEO.

    Modularize Your SCSS: While your project might be too small for extensive SCSS modularization, consider splitting your SCSS into modular components and importing everything into one main file. This approach makes debugging and updating your code easier, especially in larger projects.

    SCSS Best Practice: A good practice is to create a mixin for breakpoints, for example:

    @mixin respond-to($breakpoint) { @if $breakpoint == small { // small breakpoint styles } @else if $breakpoint == medium { // medium breakpoint styles } // Add more breakpoints here }

    @include respond-to(medium);

    (Try experimenting with different sizes for components on tablets, desktops, and so on—you’ll quickly see how useful this can be after a few breakpoints.)

    Best, Teodor

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub