Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

Product preview card component - not responsive

ouariadam•60
@ouariadam
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


i need a lot of practice, give me advices , and how i can improves my self , thank you so much ;-)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Rebecca Padgett•2,100
    @bccpadge
    Posted almost 2 years ago

    Hello @ouariadam. Welcome to Frontend Mentor Community !!!🎉

    I have few tips to improve your solution.

    HTML 📃:

    • Wrap your content using main tag because every website should have at least one landmark
    <body>
        <main></main>
        <footer></footer>
    </body>
    

    CSS 🎨:

    • Font size shouldn't be pixels because it is inaccessible for users who want to change the font size in their browser setting.

    More info📚:

    Font size shouldn't be in pixels

    • I see your product preview card component is not centered in the page.
    • You can use Flexbox or CSS Grid

    Flexbox

    body{
      display:flex;
      justify-content:center;
      align-items:center;
      min-height:100vh;
    }
    

    CSS Grid

    body{
      display:grid;
      place-content:center;
      min-height:100vh
    }
    
    • To make this component responsive you would need to add media query
    • If you haven't learned responsive design the best project to start on Frontend Mentor is the qr code component challenge.

    Hope this helps you and don't hesitate to reach out to me if you have any questions

  • P
    Jeremy Helsel•670
    @JIH7
    Posted almost 2 years ago

    Looks good on desktop! I did notice the layout isn't currently responsive so it doesn't look right on mobile. If you're not familiar with media queries, I suggest checking them out.

    Here's an article on them

    Making sure your site looks good on mobile is really important since that's the way most people engage with the web.

    Also if you add a hover effect on the button it will go a long way towards making things feel nice. Here's an easy way to do that in your CSS.

    .buy:hover{
        background-color: hsl(158, 42%, 18%);
    }
    
  • Bin•80
    @BinLama
    Posted almost 2 years ago

    Looks pretty good but try to add

    cursor: pointer;
    

    on button so that it looks like a pointer. If you want to use button tag instead of div tag for the buy button, then you can make a button and use pseudo elements to add the cart. Look at Kevin Powell's video to learn more about it.

    Also you have some random ", ." on your html so you can remove that. But overall, looks really nice!!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub