@rostyslav-nazarenko
Posted
Hi! Great result! 😀
Just a few suggestions/issues. I'm only studying so take my advice with a grant of salt.
- component breaks from 700px to 900px, limit the width of the component or set media query to trigger earlier.
img
is an inline element, most people use resets to make it display as block element that way there's no need in settingline-height
to 0, especially when you need then to set it again on text elements- for centering elements we use flexbox but it doesn't work if the parent element has no height, so that is why we set
min-height: 100vh;
to the parent element. You don't need to repeat it onbody
element and onmain
element, use only on main. And removemin-width
from both of them - Sass is a great tool but be aware of too much nesting. It creates problems with specificity in big projects.
.prouduct_outer .prouduct_body .old_price {}
is the same as.old_price{}
.
@mtaman
Posted
@rostyslav-nazarenko Thank you ) I am happy with your feedback, 😊 and I am still learning) and I am self learning.