Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Failed to decode param 'V%E1clav'
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component solution

#sass/scss
Olena Shevchenkoβ€’ 200

@olenahelena

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Would like to hear constructive criticism πŸ™‚

Community feedback

P
visualdennisβ€’ 8,255

@visualdenniss

Posted

Hello Olena,

great solution, looks almost identical to the design :)

there seems to be some areas to improve on regarding best practices of accessibility. For example: setting a fixed height like max-height: 450px; to a text containing element might cause various issues like content overflow with changing data or when user changes base font size on their device etc.

Also, for similar reasons it is better to use responsive units like rem/em than px.

there is also a great article about this particular FEM Challenge, showing and explaining best practices: Product Preview Card, feel free to check it out :)

Hope you find this feedback helpful! Keep up the great work!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord