P
visualdennis• 8,295
@visualdenniss
Posted
Hello Olena,
great solution, looks almost identical to the design :)
there seems to be some areas to improve on regarding best practices of accessibility. For example: setting a fixed height like max-height: 450px; to a text containing element might cause various issues like content overflow with changing data or when user changes base font size on their device etc.
Also, for similar reasons it is better to use responsive units like rem/em than px.
there is also a great article about this particular FEM Challenge, showing and explaining best practices: Product Preview Card, feel free to check it out :)
Hope you find this feedback helpful! Keep up the great work!
Marked as helpful
0
