Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Product preview card component solution

Prashant Uniyal•170
@mod-prashant
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What specific areas of your project would you like help with?

I would appreciate any help in making the code more professional and any improvements you think I might need

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • IO•710
    @i000o
    Posted 4 months ago

    Hi!

    Your HTML looks good - You've made semantic choices. I would only say, you could replace <span> with a heading of your choice, like a <h2>. Always use <div>/<span> as a last resort - but in your <div> case, it makes sense to create the flex alignment.

    Your CSS also looks clean - As your projects get more complex and the CSS doc longer, you can consider using a pre-processor to help organise your approach to support clarified thinking when problem-solving! It has helped me a lot when things got confusing with more content.

    I think in the design, the product title has a hover state, too. But your solution looks great, otherwise. Well done.

    Marked as helpful
  • P
    Ruben Bardok•180
    @Rubenbard
    Posted 4 months ago

    Hey Prashant, looks very good. I think were in the same boat, i also wonder if my code looks professional, I don;'t have a clue. So can't help you with that, but good job.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub