@tesla-ambassador
Posted
Hey Refael, congratulations on completing this challenge! Was it fun? I hope it was 😃 Here's a few pointers you might find useful:
- On the mobile view, your card's layout breaks making it lose it's centeredness. I looked through your code and realized that you used
grid
for your layout. Therefore, you might consider adding the following properties to yourbody
body {
height: 100vh;
background-color: var(--cream);
display: grid;
align-items: center;
justify-content: center;
}
It should center your card on both desktop and mobile view.
- In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
<main>
or<header>
or<footer>
you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
Happy coding and keep up the good work!👍
@orafaeloliveira
Posted
@tesla-ambassador Thank you for your advices! Yes, I need to use landmarks more times in my challenges, I'll remember that. And I forgot to change my mobile style, thanks for remember me. 😄