Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component solution

Solution Abiolaโ€ข 30

@Soldiamond

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The desktop design went well, but I had issues with the mobile design as I tried to use media query.

I would love it if I would be put through in this. The design was fine for Desktop, iPad, but not for mobile. Corrections and guidance are welcomed

Community feedback

Kamasah-Dicksonโ€ข 5,610

@Kamasah-Dickson

Posted

To help with your accessibility issues

  1. The main is a semantic tag that describes a section of the page and it must be used once. So wrap the main tag around the project itself(the card).
  2. Don't use sections when there is not going to be any immediate headings(h1.....h6) use divs for sections that don't.

Hope this was helpful๐Ÿ‘ Happy coding

0
Kamasah-Dicksonโ€ข 5,610

@Kamasah-Dickson

Posted

Hey there....you're doing pretty great it's just that next time approach your projects on mobile first and and use min-width media query to scale them to desktop. But first remember to look at the layout pretty well before you start with mobile first else you're going to be too hard on your self. Also always use a max-width on your containers, this will allow most of your contents to have enough breathing room. Hope this was helpful. Have a nice day and a Happy coding

0
Saulius K.โ€ข 560

@TH3RIV

Posted

Hi, now I am no expert, I just started learning myself, but to me it seems like everything is set to a fixed position not taking screen size into an account. My suggestion would be to use flexbox or grid to make it respond to how big the screen size is, as you can just position it to the center of the screen rather than giving it a fixed position. I myself love using boostrap grid to make mine responsive.

Here's a link to my solution if you want to check the code out! hopefully this would help you. Now I know my code is far from perfect, but it might give you an idea what I am on about. Good luck!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord