Adeola Ganiu• 1,320
@Deolabest
Posted
Hey @JoshuaAsistio, Congratulations on completing this challenge!
Here is my feedback:
-
It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here:
https://pixelsconverter.com/px-to-rem. -
Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
Keep doing a good job!
Marked as helpful
1
@JoshuaAsistio
Posted
@Deolabest Thank you so much for the tip! I will use this on my projects after this.
0
