Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Product preview card component using Grid and Flexbox

Carlos Chaves•260
@sircarloschaves
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


It was my first time using the grid layout in a project. I had some difficulty with the image.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P. Ricardo•2,370
    @pRicard0
    Posted over 1 year ago

    Algumas dicas HTML

    • Imagens decorativas devem sim ter atributo alt vazio e tals mas... você acha que a imagem do produto é decorativa? Eu não sei não hein, acho que talvez precise descrever a imagem no atributo alt.
    • Você deveria utilizar a tag <em> para o preço com o texto "$149.99". Essa tag significa emphasis. É usada para texto que você queira que receba ênfase. O texto vai ser lido com ênfase pelos leitores de tela.
    • Você precisa dizer se aquele botão é um botão normal ou um botão para envio de formulário, como a gente faz isso? Utilizando o atributo type. Quando não vem especificado, se não me engano ele é tratado como botão de formulário. Tem que botar type="button" para que ele se enquadre melhor nesse caso.

    Acho que só isso mesmo, o resto ta perfeito. Eu costumava utilizar a tag <s> para o outro preço mas acho que <del> é melhor mesmo. Vivendo e aprendendo.

    Marked as helpful
  • Muhammad Imran•150
    @codewithimran
    Posted over 1 year ago

    You should make it responsive. Every design must be responsive.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub