Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Product Preview Card Component with flex-box, react css-modules

react, react-router
obasekiosa•120
@obasekiosa
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Filling up vertical space in a section horizontally adjacent to an image when the height of an element has been decided by height of the image was tricky. I didn't want to have to crop the image. So shrinking the over all component width, causing the image width to shrink resulting in the height to shrink (aspect ratio). This then reduced the vertical space to fill in the adjacent section.

Also noticed wrapping an image with a styling div of fixed width, setting the width of the image to 100% of the styling div, the div's height does not fit to the image, even though the default height should be fit-content, there's always a tiny gap between both heights

I used a lot less html tags and more semantic appropriate tags, less class styling and more css selectors based styling, just like I wanted.

I also settled on picking the size of elements based on the width of the display rather than having its size super responsive (adaptive), growing and shrinking for every tiny change in display size.

Although I did play with the latter idea, and realized it could be done. It required a lot of effort, interaction decisions and edge cases to account for. Maybe I'd write about it some other time. My epistle's getting a bit too long.

next time I'd try my hands on optimising for accessibility.

Would appreciate any and all feedback/criticisms.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on obasekiosa's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.