Product Preview Card component with Grid

Community feedback

• Account deletedPosted over 2 years ago

  Hey @Toxgem, some suggestions to improve you code:

  • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images NOT images that add value and serve a purpose.

  Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  Source:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • Once you fix the image implementation, you'll want to include an Alt text tag with them. Inside that Alt Tag you want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The old price is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  Happy Coding! 👻🎃

  10

  Marked as helpful
• 

  P

  Justin Green•2,940

  @jgreen721

  Posted over 2 years ago

  I would set your main element to height:100vh; width:100vw;position:relative and use that as your app parent container. Create a separate parent-div to house both your image column and content column (and use grid on them). The parent card can be centered with display:flex;align-items:center;justify-content:center.

  With things structured like that you can then set the .attribution(footer) to position:absolute; bottom:0; left:0; width:100%; text-align:center and that should center that element.

  A lot of ways to do CSS so, this is just a suggestion. The footer can definitely be a pain in balancing with the other content. Nice job on the card though. Looks good!

  10

  Marked as helpful