@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
-
Utilize
min-h-screen
(ormin-height: 100vh
) instead ofh-screen
to prevent your component from getting shortened on mobile devices. -
The image has a margin that is too large, specifically
md:ml-[252px]
. Consider removing it for better alignment. -
The issue I notice is that you are creating two columns with
grid-cols-2
but using the same element to center them. As mentioned by Vishnu_31, consider creating another div to exclusively contain these two columns for better structure. like this:<div class="bg-cream min-h-screen w-screen flex flex-col items-center justify-center"> <div class="grid grid-cols-1 md:grid-cols-2"> <article ...></article> <div ...></div> </div> </div>
- You can use the
<picture>
tag when you have different versions of the same image 🖼. Using the<picture>
tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here 📘.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@bkarabo754
Posted
Thank you so much @MelvinAguilar, this is really helpful. I will look into it and make the necessary changes. Thank you once again, sir. :)