@Zy8712
Posted
Hi there! Your site and code look excellent!
If I really had to nitpick at one thing I'd change, it would be how you implemented the border radius.
For your container you already did border-radius: 10px 10px 10px 10px;
. Instead of adding border radius to the images, you could just add overflow: hidden
to your #container
. This will automatically hide the parts of the image that normall sticks out of the container.
In summary:
#container
already hasborder-radius: 10px 10px 10px 10px;
, so just addoverflow: hidden
- with that you can get rid of
border-radius: 0.625rem 0.625rem 0rem 0rem;
andborder-radius: 0.625rem 0rem 0rem 0.625rem;
from your classes for the images
Hope this helps 👍
Marked as helpful
@Zy8712 Thanks for taking the time to look over my site and code. I haven't used overflow that much as yet but I totally understand what you mean. It makes sense and uses less code for the same result which is more efficient and saves needless code. I'm going to give it a try...
I'm finding comments a great help as I wouldn't of thought about the overflow otherwise, much appreciated...