@correlucas
Posted
👾Hello @ravitejalakkoju, Congratulations on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
1.A better way to work this solution image, the product image is by using <picture>
to wrap it on the html instead of using it as <img>
or background-image
(with the css). Using <picture>
you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.
2.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/
3.Every page should have a h1 heading, to avoid accessibility issues replace the h5 to with <h1>
and follow the hierarchy sequence if you add another heading as h1, h2, h3…
✌️ I hope this helps you and happy coding!