Frontend Mentor | Product Preview Card coding challenge solution

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'll clean my css code

What challenges did you encounter, and how did you overcome them?

The desktop image does not occupy 100% of container's height, solved it using flex

What specific areas of your project would you like help with?

feedbacks are welcome

Community feedback

@0xabdulkhalid

Posted about 1 month ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have a suggestion regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

@lstrbvry

Posted about 1 month ago

@0xabdulkhalid Thanks bro, will do that from now on

Product Preview Card