Submitted about 1 year agoA solution to the Product preview card component challenge
Product Preview Card using SCSS and HTML
sass/scss, bem
@CrabbOO
Code
Couldn’t fetch repository
Please log in to post a comment
Log in with GitHubCommunity feedback
- @AutumnsCode
Well done, it was great coding from you.
- HTML: for accessible reason, a main-element is missing from your code. It just a small detail, but has such a power behind it. I would also use another section-element instead of the div with the class of
product__content - SCSS/CSS: I would recommand to combine scss-variable with css-variable not only for colors, but for font-size, fonts-weight, font-family etc too. In bigger project it helps to maintain your code better.
- HTML: for accessible reason, a main-element is missing from your code. It just a small detail, but has such a power behind it. I would also use another section-element instead of the div with the class of
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord