Thomas Hertog• 715
@thomashertog
Posted
visually very similar to design so kudos for that
few small improvements can be made though
- you choose a
<span>in the button to have extra styling options available, yet you didn't make use of it (because all styling was already done on the button itself), you can remove the<span>since you don't need it - the button has no
typeattribute (type=button will do) - there is still a value in
pxfor agapsomewhere in your CSS, which might not scale as well, you may want to replace this withem/rem
Marked as helpful
0
Joachim• 840
@Thewatcher13
Posted
@thomashertog
-
I can remove the span element indeed! Is it right, my "add to cart" is a label for the button so it doesn't need a tag?
-
I implement your feedback!
0
Thomas Hertog• 715
@thomashertog
Posted
@Thewatcher13 you can include a <span> if you want to, but in this case you don't need to. It also doesn't add any semantics, so it's pretty useless at this point
0
Joachim• 840
@Thewatcher13
Posted
@thomashertog Yeah I knew it, but I mean it doesn't need a tag at all bcs it is the label for my button, right?
0
Thomas Hertog• 715
@thomashertog
Posted
@Thewatcher13 exactly!
0
